Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preprocess of text #1007

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Preprocess of text #1007

wants to merge 5 commits into from

Conversation

ashishgit7
Copy link
Contributor

ad71
ad71 reviewed Jan 15, 2019
View reviewed changes
Copy link
Contributor

@ad71 ad71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lemmatization-en.txt is too big and should be a part of aima-data instead.

@ashishgit7
Copy link
Contributor Author

@ad71 lemmatization file should be bigger because we are lemmatizing word

@ashishgit7
Copy link
Contributor Author

@ad71 should I make lemmatization-en.txt part of aima-data in my pr ?

@ad71
Copy link
Contributor

ad71 commented Jan 16, 2019

@hackerashish25 Well obviously it should be big. I'm just saying that it should be a part of aima-data because it is basically a huge dataset, but this is just my opinion. Maybe wait for a collaborator to respond.

@ashishgit7
Copy link
Contributor Author

@ad71 thank you for your suggestion I'll review in my pr

@ashishgit7
Copy link
Contributor Author

@ad71 aima-data is not accepting PR for uploading lemma file lemmatization-en.txt so how to make changes in PR

@ad71
Copy link
Contributor

ad71 commented Jan 21, 2019

It'll take time. Please have patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ad71 ad71 ad71 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashishgit7 @ad71