Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked PriorityQueue and Added Tests #1025

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Reworked PriorityQueue and Added Tests #1025

merged 3 commits into from
Mar 15, 2019

Commits on Feb 10, 2019

  1. Reworked PriorityQueue spec 

    Modified:
- Priority Queue methods:
    queue[elem] now returns the first value of elem stored in queue
    elem in queue now correctly returns whether a copy of element is present regardless of the function value. Apparently the bug was introduced while trying to meet heapq spec
    del queue[elem] deletes the first instance of elem in queue correctly
- Algorithms
    Same change in best_first_graph_search in romania_problem.py and search.py to make them compatible with the new spec
- Tests
    Introduced 3 tests in test_utils.py to comprehensively test PriorityQueue's new spec
    @rajatjain1997
    rajatjain1997 committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    2c7784d View commit details
    Browse the repository at this point in the history

  2. Reworked PriorityQueue spec 

    Modified:
- Priority Queue methods:
    queue[elem] now returns the first value of elem stored in queue
    elem in queue now correctly returns whether a copy of element is present regardless of the function value. Apparently the bug was introduced while trying to meet heapq spec
    del queue[elem] deletes the first instance of elem in queue correctly
- Algorithms
    Same change in best_first_graph_search in romania_problem.py and search.py to make them compatible with the new spec
- Tests
    Introduced 3 tests in test_utils.py to comprehensively test PriorityQueue's new spec
    @rajatjain1997
    rajatjain1997 committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    d1965ca View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:rajatjain1997/aima-python

    @rajatjain1997
    rajatjain1997 committed Feb 10, 2019
    Configuration menu
    Copy the full SHA
    a1a2be3 View commit details
    Browse the repository at this point in the history