Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding joblib #843

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Embedding joblib #843

merged 3 commits into from
Aug 29, 2022

Conversation

valer1435
Copy link
Collaborator

Due to some problems with memory and performance #840. Multiprocessing was refactored using joblib library

Copy link
Collaborator

@gkirgizov gkirgizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Запускал ли, сравнивал ли с multiprocessing? Эффективнее ли по памяти?

fedot/core/optimisers/gp_comp/evaluation.py Outdated Show resolved Hide resolved
from datetime import datetime
from random import choice
from typing import Dict, Optional

from joblib import Parallel, delayed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

может выше убрать вообще импорт и использования multiprocessing

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Но импорт multiprocessing вроде остался. Или он нужен?

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #843 (e0024c4) into master (644215b) will decrease coverage by 0.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
- Coverage   87.53%   87.08%   -0.45%     
==========================================
  Files         192      192              
  Lines       13280    13278       -2     
==========================================
- Hits        11624    11563      -61     
- Misses       1656     1715      +59     
Impacted Files Coverage Δ
fedot/core/optimisers/gp_comp/evaluation.py 98.44% <100.00%> (-0.03%) ⬇️
...lementations/data_operations/ts_transformations.py 74.75% <0.00%> (-13.35%) ⬇️
fedot/core/pipelines/tuning/hyperparams.py 91.83% <0.00%> (-2.05%) ⬇️
...implementations/models/ts_implementations/naive.py 93.93% <0.00%> (-2.03%) ⬇️
fedot/core/data/merge/data_merger.py 97.87% <0.00%> (-1.07%) ⬇️
...edot/core/optimisers/gp_comp/operators/mutation.py 92.82% <0.00%> (-0.45%) ⬇️
fedot/core/composer/advisor.py 94.00% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@valer1435
Copy link
Collaborator Author

Запускал ли, сравнивал ли с multiprocessing? Эффективнее ли по памяти?

Тестов не проводил. Хорошо то, что перестал падать у меня пример api_classification. До этого у меня ноут с 16 гб оперативы просто вылетал

@nicl-nno
Copy link
Collaborator

image

А вот этот вывод можно сделать опциальным?

@valer1435
Copy link
Collaborator Author

image

А вот этот вывод можно сделать опциальным?

Можно его вообще убрать. Но я так понимаю, скоро будет обновление логгинга и выставление отдельного уровня логирования для композирования(?)

@nicl-nno
Copy link
Collaborator

Да, но его все равно надо будет связывать с job-libом. Ну давай пока вообще отключим.

@valer1435 valer1435 merged commit 4964f64 into master Aug 29, 2022
@valer1435 valer1435 deleted the joblib_parallel branch August 29, 2022 08:59
@gkirgizov gkirgizov mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants