-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedding joblib #843
Embedding joblib #843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Запускал ли, сравнивал ли с multiprocessing? Эффективнее ли по памяти?
from datetime import datetime | ||
from random import choice | ||
from typing import Dict, Optional | ||
|
||
from joblib import Parallel, delayed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
может выше убрать вообще импорт и использования multiprocessing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Но импорт multiprocessing вроде остался. Или он нужен?
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
==========================================
- Coverage 87.53% 87.08% -0.45%
==========================================
Files 192 192
Lines 13280 13278 -2
==========================================
- Hits 11624 11563 -61
- Misses 1656 1715 +59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Тестов не проводил. Хорошо то, что перестал падать у меня пример api_classification. До этого у меня ноут с 16 гб оперативы просто вылетал |
Да, но его все равно надо будет связывать с job-libом. Ну давай пока вообще отключим. |
1f34f56
to
e0024c4
Compare
Due to some problems with memory and performance #840. Multiprocessing was refactored using joblib library