Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add ability to create reports #3189

Merged
merged 28 commits into from
Sep 27, 2024
Merged

[feat] Add ability to create reports #3189

merged 28 commits into from
Sep 27, 2024

Conversation

mihran113
Copy link
Contributor

No description provided.

@mihran113 mihran113 marked this pull request as ready for review July 16, 2024 22:34
SGevorg
SGevorg requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@SGevorg SGevorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments for the docs.

docs/source/ui/pages/reports.md Outdated Show resolved Hide resolved
docs/source/ui/pages/reports.md Outdated Show resolved Hide resolved
docs/source/ui/pages/reports.md Outdated Show resolved Hide resolved
docs/source/ui/pages/reports.md Outdated Show resolved Hide resolved
docs/source/ui/pages/reports.md Outdated Show resolved Hide resolved
docs/source/ui/pages/reports.md Outdated Show resolved Hide resolved
docs/source/ui/pages/reports.md Show resolved Hide resolved
docs/source/ui/pages/reports.md Outdated Show resolved Hide resolved
docs/source/ui/pages/reports.md Outdated Show resolved Hide resolved
alberttorosyan
alberttorosyan approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@alberttorosyan alberttorosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went over backend changes and docs. BE looks good. Some minor things to be changed in the docs, already covered by Gev's feedback.

@mihran113
Copy link
Contributor Author

Left comments for the docs.

@SGevorg all the requested changes are addressed. Could you please have a look, and approve?

SGevorg
SGevorg approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@SGevorg SGevorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mihran113 mihran113 merged commit 2b06dff into main Sep 27, 2024
3 of 4 checks passed
@mihran113 mihran113 deleted the feature/reports branch September 27, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SGevorg SGevorg SGevorg approved these changes

@alberttorosyan alberttorosyan alberttorosyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihran113 @SGevorg @alberttorosyan