Change logic to handle async response #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjoshi30
reviewed
Dec 4, 2024
aimon/decorators/detect.py
Outdated
| self.publish_response = publish if publish is not None else [] | ||
|
|
||
| # Format or convert detect_response during initialization | ||
| if self.async_mode: |
There was a problem hiding this comment.
lets keep these as objects when returning.
pjoshi30
reviewed
Dec 4, 2024
aimon/decorators/detect.py
Outdated
| detect_response_value = ( | ||
| detect_response.to_dict() if hasattr(detect_response, 'to_dict') else detect_response | ||
| ) | ||
| self.detect_response = self._format_response_item(detect_response_value) |
pjoshi30
reviewed
Dec 4, 2024
aimon/decorators/detect.py
Outdated
| return ( | ||
| f"DetectResult(\n" | ||
| f" status={self.status},\n" | ||
| f" detect_response={detect_response_str},\n" | ||
| f" detect_response={self.detect_response},\n" |
There was a problem hiding this comment.
instead format the object in a pretty string format here using _format_response_item
pjoshi30
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.