This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Fix Python 3.8 warnings #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
- Coverage 97.07% 97.06% -0.02%
==========================================
Files 57 57
Lines 8493 8111 -382
Branches 573 568 -5
==========================================
- Hits 8245 7873 -372
+ Misses 176 172 -4
+ Partials 72 66 -6
Continue to review full report at Codecov.
|
wmorrell
added a commit
to wmorrell/channels_redis
that referenced
this pull request
May 27, 2020
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling create_redis. See aio-libs-abandoned/aioredis-py#666 and django#179. When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop parameter. Otherwise, continue to include the parameter for the older versions that expect it.
wmorrell
added a commit
to wmorrell/channels_redis
that referenced
this pull request
Jun 15, 2020
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling create_redis. See aio-libs-abandoned/aioredis-py#666 and django#179. When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop parameter. Otherwise, continue to include the parameter for the older versions that expect it.
carltongibson
pushed a commit
to django/channels_redis
that referenced
this pull request
Jun 25, 2020
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling create_redis. See aio-libs-abandoned/aioredis-py#666 and #179. When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop parameter. Otherwise, continue to include the parameter for the older versions that expect it.
dudleyhunt86
added a commit
to dudleyhunt86/channels_redis-python-dev
that referenced
this pull request
Oct 7, 2022
Starting with aioredis 1.3.1, the loop parameter is deprecated when calling create_redis. See aio-libs-abandoned/aioredis-py#666 and django/channels_redis#179. When running Python 3.8+ and aioredis 1.3.1+, calls should omit the loop parameter. Otherwise, continue to include the parameter for the older versions that expect it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Remove
loopargument.Are there changes in behavior for the user?
Nope
Related issue number
#648
Checklist
CONTRIBUTORS.txt<Name> <Surname>.CHANGES/folder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.