-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support up-to-date botocore
#1063
Conversation
f5895b6
to
600af7f
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1063 +/- ##
==========================================
- Coverage 86.46% 86.13% -0.34%
==========================================
Files 60 60
Lines 5814 5863 +49
==========================================
+ Hits 5027 5050 +23
- Misses 787 813 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
29e1a76
to
8e7c2bc
Compare
fca553f
to
72f5ad6
Compare
@thehesiod: Another bump that adds support for new AWS services and features. I'm unsure how to deal with the lack of test coverage. Is this something to be concerned about? |
72f5ad6
to
0c9b502
Compare
not reaaaly, bonus if they're added. We should probably have a task to port all the botocore tests over |
will get to this today |
0c9b502
to
0fa1827
Compare
I just pushed another update that extends compatibility up to yesterday's botocore release. It's all yours now ;-) |
whoops didn't get to it. will do asap |
0fa1827
to
ede128d
Compare
ede128d
to
ef378b7
Compare
going to do version w/o prefix this time, see how it goes |
thanks for all the help! |
I liked your strategy of supporting multiple botocore versions, probably worth adding to the docs describing how to do upgrades |
actually was thinking about this last night, we can probably add a python helper where you set a base revision, and it tells you which ranges have only service json changes. Would save a lot of manual labor. |
That's true. To reach the next level of automation, it would be nice to run a scheduled GitHub action that checks for new botocore releases and opens PRs, if these are light-weight, i.e. only contain service JSON updates. Once that is stable, these PRs could even be auto-merged after passing CI. Eventually, we could also do automated minor releases. |
i like your thinking :] |
Description of Change
This PR intends to improve general compatibility of
aiobotocore
within the Python ecosystem by bumping the dependency specification ofbotocore
, as well asboto3
andawscli
.It also restores feature parity with respect to recently released and improved AWS services, in particular adding support for S3 Express One Zone.
Assumptions
Upstream diff contains multiple changes that affect this codebase.
Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions