Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose http_session_cls in AioConfig #1102

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

jakkdl
Copy link
Contributor

@jakkdl jakkdl commented Mar 20, 2024

Description of Change

This is split out from #1085, partly to make the diff smaller, and partly because it could on its own open up another avenue of achieving the same goal - where an end user/plugin/etc could supply a custom class that e.g. doesn't depend on aiohttp.

If #1085 is considered too crude/messy, and/or not wanting the tough tradeoff between maintaining both aiohttp+httpx vs dropping aiohttp-only functionality, this + a separate PR to replace asyncio usage with anyio could perhaps achieve #749 while still only using aiohttp in this repository (for now).

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details): groundwork for support pluggable http clients/coroutine frameworks (anyio/httpx) #749
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

aiobotocore/config.py Outdated Show resolved Hide resolved
@thehesiod
Copy link
Collaborator

go ahead and set the next patch version with date and I'll merge and release

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.29%. Comparing base (8294d52) to head (d12348c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1102      +/-   ##
==========================================
+ Coverage   86.25%   86.29%   +0.04%     
==========================================
  Files          62       62              
  Lines        5891     5910      +19     
==========================================
+ Hits         5081     5100      +19     
  Misses        810      810              
Flag Coverage Δ
unittests 86.29% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakkdl
Copy link
Contributor Author

jakkdl commented Apr 1, 2024

go ahead and set the next patch version with date and I'll merge and release

done!

@thehesiod thehesiod merged commit a904bd1 into aio-libs:master Apr 2, 2024
12 checks passed
@jakkdl jakkdl deleted the http_session_cls branch April 3, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants