-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #1125 due to missing aync override #1126
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1126 +/- ##
==========================================
- Coverage 86.33% 86.14% -0.19%
==========================================
Files 62 62
Lines 5913 5933 +20
==========================================
+ Hits 5105 5111 +6
- Misses 808 822 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
i added a test but it doesn't seem like moto completely supports it, I tried updating moto but I need to re-architect how the moto service works because apparently now you only need one (yay) |
did the re-architect, and a ton of tests break due to incompatibilities between botocore/moto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
put the changes in a branch, we can re-visit it later |
No description provided.