Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI for Python 3.13 #1127

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

jakob-keller
Copy link
Collaborator

Description of Change

Python 3.13 is being finalized and the final beta has just been released:

We strongly encourage maintainers of third-party Python projects to test with 3.13 during the beta phase...

Note: This PR neither drops support for Python 3.8 not does it declare support for Python 3.13, i.e. in docs or PyPI trove classifiers. Both should be addressed separately, preferable around the time the final version of Python 3.13 is released.

Assumptions

Compatibility of aiobotocore with Python 3.13 should be tested ahead of its final launch.

@jakob-keller jakob-keller self-assigned this Jul 18, 2024
@jakob-keller jakob-keller added the github_actions Pull requests that update GitHub Actions code label Jul 18, 2024
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.16%. Comparing base (7154abc) to head (c023c3f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
+ Coverage   86.14%   86.16%   +0.01%     
==========================================
  Files          62       62              
  Lines        5933     5933              
==========================================
+ Hits         5111     5112       +1     
+ Misses        822      821       -1     
Flag Coverage Δ
unittests 86.16% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller force-pushed the python-3.13 branch 2 times, most recently from bbdf8d7 to 6a37e9b Compare July 18, 2024 16:05
@jakob-keller
Copy link
Collaborator Author

A number of tests are failing. I believe there are several underlying issues with dependencies, including python-cffi/cffi#77. I will retry as soon as those are resolved.

@thehesiod
Copy link
Collaborator

bonus points for tackling latest moto too. I pushed a branch with the changes required to get it running

@yan12125
Copy link
Contributor

A number of tests are failing. I believe there are several underlying issues with dependencies, including python-cffi/cffi#77. I will retry as soon as those are resolved.

https://github.com/python-cffi/cffi/releases/tag/v1.17.0rc1 mentions Python 3.13. How about temporarily using cffi==1.17.0rc1 in CI?

@thehesiod
Copy link
Collaborator

as noted in other pr, changes for moto 5.x here: https://github.com/aio-libs/aiobotocore/compare/thehesiod/aio-checksum-streaming-moto-bump

@jakob-keller jakob-keller marked this pull request as ready for review August 6, 2024 20:34
@thehesiod thehesiod merged commit 2bd2c77 into aio-libs:master Aug 6, 2024
13 checks passed
@jakob-keller jakob-keller deleted the python-3.13 branch August 6, 2024 21:05
chemelli74 pushed a commit to chemelli74/aiobotocore that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants