Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support up-to-date botocore #1131

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Aug 10, 2024

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by relaxing the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

  • Upstream diff contains no relevant functional changes that require adjustments to the aiobotocore codebase.
  • Upstream modernized its tooling, replacing pyupgrade, black, and flake8 by ruff. As a result, there are numerous formatting related diffs, which have been integrated into this codebase.
  • In order to keep tooling aligned with upstream, aiobotocore also migrates to ruff for linting and formatting. This results in a number of additional changes, primarily related to formatting.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.03%. Comparing base (42c8caa) to head (433470c).
Report is 16 commits behind head on master.

Files Patch % Lines
aiobotocore/httpchecksum.py 0.00% 3 Missing ⚠️
aiobotocore/client.py 75.00% 1 Missing ⚠️
aiobotocore/retryhandler.py 0.00% 1 Missing ⚠️
aiobotocore/waiter.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
- Coverage   87.03%   87.03%   -0.01%     
==========================================
  Files          64       64              
  Lines        5970     5969       -1     
==========================================
- Hits         5196     5195       -1     
  Misses        774      774              
Flag Coverage Δ
unittests 87.03% <78.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller marked this pull request as ready for review August 10, 2024 22:20
@jakob-keller jakob-keller self-assigned this Aug 10, 2024
@jakob-keller jakob-keller force-pushed the bump-botocore branch 5 times, most recently from 82bdfcd to f0dd3c4 Compare August 16, 2024 08:41
@jakob-keller
Copy link
Collaborator Author

@thehesiod: botocore just released 1.35.0 which contains a bunch of new logic. Before diving into that, I would love to merge this PR which provides compatibility for all recent 1.34.x releases.

Despite what codecov reports, test coverage is not actually any worse. The changes are purely due to new formatting provided by ruff. Yet, this is still blocking auto-merging for me.

Thanks for reviewing!

@jakob-keller jakob-keller marked this pull request as draft August 17, 2024 22:17
@jakob-keller jakob-keller removed the request for review from thehesiod August 17, 2024 22:17
@jakob-keller jakob-keller force-pushed the bump-botocore branch 2 times, most recently from 08f7602 to 95f6e63 Compare August 18, 2024 00:46
@jakob-keller jakob-keller marked this pull request as ready for review August 18, 2024 00:51
@jakob-keller jakob-keller force-pushed the bump-botocore branch 2 times, most recently from 7c597a4 to 0302535 Compare August 18, 2024 22:17
@jakob-keller
Copy link
Collaborator Author

@thehesiod: This would be the first PR to review ;-)

@jakob-keller
Copy link
Collaborator Author

@thehesiod: Thanks for reviewing and approving! You would need to perform the merge, since CodeCov isn't happy (enough). Also, this would be a candidate for a release, if you don't mind.

@thehesiod thehesiod merged commit 41112b8 into aio-libs:master Aug 19, 2024
10 of 11 checks passed
@jakob-keller jakob-keller deleted the bump-botocore branch August 19, 2024 19:23
@jakob-keller
Copy link
Collaborator Author

Sorry, for all these PRs: I hope I'm not bothering you too much, @thehesiod!

@thehesiod
Copy link
Collaborator

Sorry, for all these PRs: I hope I'm not bothering you too much, @thehesiod!

no bother at all! thank you for all the help!

@jakob-keller jakob-keller added dependencies Pull requests that update a dependency file and removed deps-update labels Aug 20, 2024
chemelli74 pushed a commit to chemelli74/aiobotocore that referenced this pull request Aug 29, 2024
chemelli74 pushed a commit to chemelli74/aiobotocore that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants