-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support up-to-date botocore
#1131
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1131 +/- ##
==========================================
- Coverage 87.03% 87.03% -0.01%
==========================================
Files 64 64
Lines 5970 5969 -1
==========================================
- Hits 5196 5195 -1
Misses 774 774
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
82bdfcd
to
f0dd3c4
Compare
@thehesiod: botocore just released 1.35.0 which contains a bunch of new logic. Before diving into that, I would love to merge this PR which provides compatibility for all recent 1.34.x releases. Despite what codecov reports, test coverage is not actually any worse. The changes are purely due to new formatting provided by ruff. Yet, this is still blocking auto-merging for me. Thanks for reviewing! |
08f7602
to
95f6e63
Compare
7c597a4
to
0302535
Compare
@thehesiod: This would be the first PR to review ;-) |
0302535
to
433470c
Compare
@thehesiod: Thanks for reviewing and approving! You would need to perform the merge, since CodeCov isn't happy (enough). Also, this would be a candidate for a release, if you don't mind. |
Sorry, for all these PRs: I hope I'm not bothering you too much, @thehesiod! |
no bother at all! thank you for all the help! |
Description of Change
This PR intends to improve general compatibility of
aiobotocore
within the Python ecosystem by relaxing the dependency specification ofbotocore
, as well asboto3
andawscli
.Assumptions
aiobotocore
codebase.pyupgrade
,black
, andflake8
byruff
. As a result, there are numerous formatting related diffs, which have been integrated into this codebase.aiobotocore
also migrates toruff
for linting and formatting. This results in a number of additional changes, primarily related to formatting.Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions