Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support up-to-date botocore #1136

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

jakob-keller
Copy link
Collaborator

@jakob-keller jakob-keller commented Aug 17, 2024

Description of Change

This PR intends to improve general compatibility of aiobotocore within the Python ecosystem by bumping the dependency specification of botocore, as well as boto3 and awscli.

Assumptions

Upstream diff contains functional changes that require minor adjustments to the aiobotocore codebase.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.99%. Comparing base (6c13b2c) to head (357c71f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
+ Coverage   86.93%   86.99%   +0.05%     
==========================================
  Files          64       64              
  Lines        5978     5982       +4     
==========================================
+ Hits         5197     5204       +7     
+ Misses        781      778       -3     
Flag Coverage Δ
unittests 86.99% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Makefile Outdated Show resolved Hide resolved
aiobotocore/client.py Outdated Show resolved Hide resolved
@jakob-keller jakob-keller force-pushed the bump-botocore-1.35 branch 3 times, most recently from 2df7460 to b0f701a Compare August 20, 2024 08:49
@jakob-keller jakob-keller added dependencies Pull requests that update a dependency file and removed deps-update labels Aug 20, 2024
@jakob-keller jakob-keller force-pushed the bump-botocore-1.35 branch 2 times, most recently from 083fe40 to 5782040 Compare August 21, 2024 13:18
CHANGES.rst Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@jakob-keller jakob-keller force-pushed the bump-botocore-1.35 branch 2 times, most recently from 6c50add to 009b58e Compare August 22, 2024 20:50
@jakob-keller jakob-keller marked this pull request as ready for review August 22, 2024 20:51
@jakob-keller jakob-keller merged commit 51d471d into aio-libs:master Aug 23, 2024
11 checks passed
@jakob-keller jakob-keller deleted the bump-botocore-1.35 branch August 23, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants