-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline use of pre-commit
in GitHub workflows
#1186
Streamline use of pre-commit
in GitHub workflows
#1186
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1186 +/- ##
=======================================
Coverage 86.94% 86.94%
=======================================
Files 64 64
Lines 5983 5983
=======================================
Hits 5202 5202
Misses 781 781
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e646c69
to
d820298
Compare
It's usually good to move it into the regular CI/CD workflow. pre-commit.ci has some limitations when it comes to linters needing network access or external environments (which can be the case for pylint). |
d820298
to
1856ef6
Compare
Pre PR we were running pre-commit hooks up to three times on GitHub:
This PR would run 1. across the entire matrix (currently Python 3.8 - 3.13) and remove 2. Further improvements, such as introducing tox, are out of scope of this PR. |
pre-commit
pre-commit
in GitHub workflows
1856ef6
to
c4b6995
Compare
Description of Change
Assumptions
pre-commit
in GitHub workflows #1186 (comment)Checklist for All Submissions
Checklist when updating botocore and/or aiohttp versions