Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Botocore to 1.35.22 #1206

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

paulcichonski
Copy link
Contributor

@paulcichonski paulcichonski commented Sep 19, 2024

Description of Change

Updates Botocore higher bound to 1.35.22. This is mainly so I can pull in the boto3 updates for a project I'm working on without causing version errors with aiobotocore.

The changelog from botocore this introduces doesn't seem to introduce any changes that require corresponding updates to the aiobotocore python code:

$ git diff --name-status 1.35.16...1.35.22 botocore | grep py$
M	botocore/__init__.py
M	botocore/configprovider.py
M	botocore/eventstream.py
M	botocore/utils.py

Manually comparing the diff of those files to the classes implemented in aiobotocore/ showed no overlap.

Assumptions

This is my first time working on this repo, I followed the instructions in the CONTRIBUTING doc, so I think I covered all the steps.

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

@jakob-keller jakob-keller self-assigned this Sep 19, 2024
@jakob-keller jakob-keller added the dependencies Pull requests that update a dependency file label Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.95%. Comparing base (9e0ad8c) to head (7c3634a).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1206      +/-   ##
==========================================
- Coverage   87.00%   86.95%   -0.06%     
==========================================
  Files          64       64              
  Lines        5986     5986              
==========================================
- Hits         5208     5205       -3     
- Misses        778      781       +3     
Flag Coverage Δ
unittests 86.95% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller jakob-keller merged commit 6417804 into aio-libs:master Sep 19, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants