Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes header case and brings in line with botocore #132

Merged
merged 6 commits into from
Mar 7, 2017

Conversation

thehesiod
Copy link
Collaborator

@thehesiod thehesiod commented Mar 7, 2017

this fixes #131 by using the same case insensitive dict that botocore uses.

@thehesiod
Copy link
Collaborator Author

I'm merging ignoring the delta coverage for endpoint.py since I just moved code. This code is copied from botocore and we never had tests for them before.

@codecov-io
Copy link

Codecov Report

Merging #132 into master will increase coverage by 3.31%.
The diff coverage is 60%.

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   81.63%   84.94%   +3.31%     
==========================================
  Files           7        7              
  Lines         392      392              
==========================================
+ Hits          320      333      +13     
+ Misses         72       59      -13
Impacted Files Coverage Δ
aiobotocore/config.py 100% <100%> (+41.17%)
aiobotocore/endpoint.py 84.32% <55.55%> (-0.75%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0adb2c8...cac5f62. Read the comment docs.

@thehesiod thehesiod merged commit 4affcad into master Mar 7, 2017
@thehesiod thehesiod deleted the thehesiod-bugfix branch March 7, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

head_object is broken
2 participants