Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the list #969

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Remove the list #969

merged 1 commit into from
Sep 19, 2022

Conversation

Fokko
Copy link
Contributor

@Fokko Fokko commented Sep 9, 2022

Description of Change

No need to construct a list. Found this when debugging some code

Assumptions

Replace this text with any assumptions made (if any)

Checklist for All Submissions

  • I have added change info to CHANGES.rst
  • If this is resolving an issue (needed so future developers can determine if change is still necessary and under what conditions) (can be provided via link to issue with these details):
    • Detailed description of issue
    • Alternative methods considered (if any)
    • How issue is being resolved
    • How issue can be reproduced
  • If this is providing a new feature (can be provided via link to issue with these details):
    • Detailed description of new feature
    • Why needed
    • Alternatives methods considered (if any)

Checklist when updating botocore and/or aiohttp versions

  • I have read and followed CONTRIBUTING.rst
  • I have updated test_patches.py where/if appropriate (also check if no changes necessary)
  • I have ensured that the awscli/boto3 versions match the updated botocore version

No need to construct a list
@codecov
Copy link

codecov bot commented Sep 11, 2022

Codecov Report

Merging #969 (53a4480) into master (fbfeb12) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #969   +/-   ##
=======================================
  Coverage   86.77%   86.77%           
=======================================
  Files          55       55           
  Lines        5322     5322           
=======================================
  Hits         4618     4618           
  Misses        704      704           
Flag Coverage Δ
unittests 86.77% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiobotocore/config.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thehesiod thehesiod merged commit 585d6ff into aio-libs:master Sep 19, 2022
@Fokko Fokko deleted the patch-1 branch September 20, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants