-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove aiocache.Cache and alias support #948
Remove aiocache.Cache and alias support #948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking at this. Seems to a very thorough PR.
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #948 +/- ##
==========================================
- Coverage 99.76% 99.64% -0.12%
==========================================
Files 36 33 -3
Lines 3794 3396 -398
==========================================
- Hits 3785 3384 -401
- Misses 9 12 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
@Dreamsorcerer could you run the lint again? |
Yep, sorry, missed the last change. |
Apologies - some bad testing on my part, but also the linter on CI is different to We should update the docs with precommit support and add a Please run the lint again @Dreamsorcerer , it should be good now. |
Yeah, that'd be good. Also hoping to find some time to start some org-wide work on this stuff in future, so we can keep all repos in sync. |
What do these changes do?
Removes factory.py and associated factory tooling. Updates all the tests and documentation to reflect the changes.
Added a Migration guide to start documenting the changes for a v1 release.
Are there changes in behavior for the user?
Related issue number
Closes #677
Checklist