Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional parameters in swarm init #323

Open
SoerenBusse opened this issue Sep 16, 2019 · 1 comment
Open

Support additional parameters in swarm init #323

SoerenBusse opened this issue Sep 16, 2019 · 1 comment

Comments

@SoerenBusse
Copy link

SoerenBusse commented Sep 16, 2019

Long story short

Currently there is no way to set some additional parameters when creating a swarm. For example "DefaultAddrPool" is missing as it exists in the documentation: https://docs.docker.com/engine/api/v1.40/#operation/SwarmInit

The code only allows some predefined parameters:

data = {
"AdvertiseAddr": advertise_addr,
"ListenAddr": listen_addr,
"ForceNewCluster": force_new_cluster,
"Spec": swarm_spec,
}

Maybe it would be possible to allow kwargs to specify custom parameters?

@asvetlov
Copy link
Member

Sorry, **kwargs is a bad option for many reasons, the lack of typing info is on the list.
Please enumerate all missing args explicitly as we do already for a few, e.g. advertise_addr.

The test is welcome!

akiuni pushed a commit to akiuni/aiodocker that referenced this issue Jul 23, 2021
akiuni pushed a commit to akiuni/aiodocker that referenced this issue Jul 23, 2021
achimnol added a commit that referenced this issue May 21, 2024
Co-authored-by: Julien Simbola <julien.simbolaa@rohde-schwarz.com>
Co-authored-by: Joongi Kim <me@daybreaker.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants