Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cid is optional if uid is used. #5

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

eventh
Copy link
Contributor

@eventh eventh commented Jun 27, 2018

When using the uid parameter, cid is optional, see [1].

[1] https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#cid

Signed-off-by: Even Thomassen even.thomassen@noriginmedia.com

Even Thomassen added 2 commits June 27, 2018 23:50
Signed-off-by: Even Thomassen <even.thomassen@noriginmedia.com>
@eventh
Copy link
Contributor Author

eventh commented Jun 28, 2018

Tests fails because of python3.4 no longer supported.
Please merge #6 before this can be merged.

@eventh
Copy link
Contributor Author

eventh commented Oct 20, 2018

I closed #6 by accident when I was updated it, but #7 is now ready to be merged, to fix the failing tests.

Please merge #7 and this one!

@CLAassistant

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants