Fix NaClCookieStorage for corrupt cookie generating error 500 #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tardyp
commented
Sep 10, 2018
aiohttp_session/nacl_storage.py
Outdated
| encoder=Base64Encoder).decode('utf-8') | ||
| ) | ||
| return Session(None, data=data, new=False, max_age=self.max_age) | ||
| except (binascii.Error, nacl.exceptions.CryptoError): |
There was a problem hiding this comment.
Not sure if we shouldn't just catch all exceptions
tardyp
force-pushed
the
NaClCookieStorage
branch
from
e7d7421 to
7240128
Compare
tardyp
changed the title
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
=========================================
+ Coverage 97.08% 97.2% +0.12%
=========================================
Files 4 4
Lines 206 215 +9
Branches 25 25
=========================================
+ Hits 200 209 +9
Misses 4 4
Partials 2 2
Continue to review full report at Codecov.
|
asvetlov
approved these changes
Sep 12, 2018
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #316