Serve static Brotli compressed files #8062
Labels
Comments
5 tasks
webknjaz
added a commit
that referenced
this issue
Feb 14, 2024
) Currently server only checks if static routes have a `.gz` extension and serves them with `gzip` encoding. These changes do the same for `.br` files with `br` encoding. Brotli is prioritized over gzip if both exist and are supported by the client, as it should almost always be a smaller content length. I considered making a check for which is smaller if both exist, but figured it wouldn't be worth the extra file system call in the vast majority of cases (at least not for typical web formats). Users should simply use gzip if it's smaller than Brotli for any file. Resolves #8062 Co-authored-by: J. Nick Koston <nick@koston.org> Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
steverep
added a commit
to steverep/aiohttp
that referenced
this issue
Feb 14, 2024
…les (aio-libs#8063) Currently server only checks if static routes have a `.gz` extension and serves them with `gzip` encoding. These changes do the same for `.br` files with `br` encoding. Brotli is prioritized over gzip if both exist and are supported by the client, as it should almost always be a smaller content length. I considered making a check for which is smaller if both exist, but figured it wouldn't be worth the extra file system call in the vast majority of cases (at least not for typical web formats). Users should simply use gzip if it's smaller than Brotli for any file. Resolves aio-libs#8062 (cherry picked from commit dfc9296) Co-authored-by: Steve Repsher <steverep@users.noreply.github.com> Co-authored-by: J. Nick Koston <nick@koston.org> Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
5 tasks
webknjaz
pushed a commit
that referenced
this issue
Feb 14, 2024
…les (#8160) Currently server only checks if static routes have a `.gz` extension and serves them with `gzip` encoding. These changes do the same for `.br` files with `br` encoding. Brotli is prioritized over gzip if both exist and are supported by the client, as it should almost always be a smaller content length. I considered making a check for which is smaller if both exist, but figured it wouldn't be worth the extra file system call in the vast majority of cases (at least not for typical web formats). Users should simply use gzip if it's smaller than Brotli for any file. Resolves #8062 Co-authored-by: J. Nick Koston <nick@koston.org> Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com> (cherry picked from commit dfc9296)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem?
Currently only the aiohttp client supports Brotli compression, and the aiohttp server is missing such capability for even just serving Brotli files that are statically compressed by the user (i.e. a file with the
.brextension exists).Describe the solution you'd like
For static requests, server should look for
.brfile extension in addition to.gz, and prefer Brotli over GZip if both exist.I will submit a PR shortly for this. I opened the issue as a formality.
Describe alternatives you've considered
None
Related component
Server
Additional context
#2518 is obviously a similar feature request, but this request focuses on just starting with precompressed Brotli capability, and then expanding to dynamic compression.
Code of Conduct
The text was updated successfully, but these errors were encountered: