[PR #10095/fcce1bf6 backport][3.12] Add a benchmark for web.FileResponse #10098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
bdraco
approved these changes
Dec 3, 2024
CodSpeed Performance ReportMerging #10098 will not alter performanceComparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 3.12 #10098 +/- ##
=======================================
Coverage 98.06% 98.06%
=======================================
Files 122 123 +1
Lines 37051 37089 +38
Branches 4453 4457 +4
=======================================
+ Hits 36334 36372 +38
Misses 540 540
Partials 177 177
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
deleted the
patchback/backports/3.12/fcce1bf6a5c339a3d63ab1678dcb6658ffc7d570/pr-10095
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #10095 as merged into master (fcce1bf).
We didn't have any benchmarks for file responses. From the benchmarks it turns out most of the time is creating and processing the executor jobs.
If we combine the stat into a job that returns the open fileobj it will likely be faster and solve #8013