use aiodns.DNSResolver.gethostbyname()

[Martiusweb]

aiodns 1.1 has been released this weekend, it adds the support of DNSResolver.gethostbyname(). This PR updates aiohttp.resolver.AsyncResolver to use it.

The main difference between DNSResolver.query() and gethostbyname() is that the latter works more like getaddrinfo() and reads /etc/hosts before it tries to issue a query to a DNS server. It effectively allows to use local hostnames such as localhost.

I don't know if it's better to require aiodns 1.1 or if the code should instead check if gethostbyname() is available and fallback to query() if not. We can also add a third Resolver class instead of modifying AsyncResolver, but it don't think that's really useful.

In the first case, I will add the requirement notice in the documentation/readme/requirements, otherwise I can rewrite the PR.

[codecov-io]

Current coverage is 98.28% (diff: 100%)

Merging #1136 into master will increase coverage by <.01%

@@             master      #1136   diff @@
==========================================
  Files            28         28          
  Lines          6465       6474     +9   
  Methods           0          0          
  Messages          0          0          
  Branches       1083       1085     +2   
==========================================
+ Hits           6354       6363     +9   
  Misses           61         61          
  Partials         50         50          

Powered by Codecov. Last update 77fa3b5...f31b009

[asvetlov]

Cool!
The patch should support both versions.
I suggest to check for _resolver.gethostbyname existence in the constructor an call appropriate method.

[Martiusweb]

Hi,

I updated my patch, rebased master and eventually defeated the CI and coverage checks. Tell me if there is something missing.

[asvetlov]

Thanks!

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.