Fixed stream reading method of BodyPartReader #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method BodyPartHeader._read_chunk_from_stream from aiohttp.multipart module was returning an zero length Byte object before reaching EOF while reading a part in a muiltipart request. Added missing virtualenv activation instructions in "CONTRIBUTING.rst". Fixed a typo in the docs. Fixes #1428.
Current coverage is 98.84% (diff: 100%)@@ 1.1 #1431 diff @@
==========================================
Files 29 29
Lines 6783 6779 -4
Methods 0 0
Messages 0 0
Branches 1129 1128 -1
==========================================
Hits 6701 6701
+ Misses 38 35 -3
+ Partials 44 43 -1
|
|
+1 |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
BodyPartHeader._read_chunk_from_streamfromaiohttp.multipartmodule was returning an zero length Byte object before reaching EOF while reading a part in a multipart request.Added missing virtualenv activation instructions in
CONTRIBUTING.rst.Fixed a typo in the docs.
Fixes #1428.