Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pause transport during set_parser stage #1551

Merged
merged 2 commits into from
Jan 23, 2017
Merged

Conversation

fafhrd91
Copy link
Member

Added allow_pause to flow control related streams, so we can prevent transport pausing during set_parser stage. this should solve #1211

@asvetlov @kxepal i need your review and thoughts

@codecov-io
Copy link

codecov-io commented Jan 23, 2017

Current coverage is 98.92% (diff: 100%)

Merging #1551 into master will increase coverage by <.01%

@@             master      #1551   diff @@
==========================================
  Files            30         30          
  Lines          6995       7000     +5   
  Methods           0          0          
  Messages          0          0          
  Branches       1169       1169          
==========================================
+ Hits           6920       6925     +5   
  Misses           37         37          
  Partials         38         38          

Powered by Codecov. Last update 1d0750e...d6e1601

@fafhrd91 fafhrd91 force-pushed the delay-transport-pause branch from a88e887 to cbdfbb9 Compare January 23, 2017 17:32
@fafhrd91
Copy link
Member Author

i think pause_reading should be no-op during transport closing.

@fafhrd91 fafhrd91 merged commit 49b593e into master Jan 23, 2017
@fafhrd91 fafhrd91 deleted the delay-transport-pause branch January 23, 2017 18:25
@asvetlov
Copy link
Member

I think allow_pause should be a private attribute (_allow_pause).
Otherwise we need to document it.

@fafhrd91
Copy link
Member Author

good point, will change

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants