Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix web.run_app not to bind to default host:port if only socket is passed #1786

Merged
merged 3 commits into from
Apr 5, 2017

Conversation

popravich
Copy link
Member

@popravich popravich commented Apr 5, 2017

What do these changes do?

web.run_app fix to create server only for specified socket if no other arguments are passed.
Currently, run_app will also bind to default host if only socket is passed which is wrong.

Are there changes in behavior for the user?

no

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new entry to CHANGES.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using #issue_number format at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.

@popravich popravich changed the title add failing test for web.run_app when only socket is passed Fix web.run_app not to bind to default host:port if only socket is passed Apr 5, 2017
@popravich
Copy link
Member Author

cc: @fafhrd91, @kxepal

@kxepal
Copy link
Member

kxepal commented Apr 5, 2017

LGFM

@popravich popravich merged commit 554e45f into master Apr 5, 2017
@popravich popravich deleted the run_app_fix branch April 5, 2017 11:29
@fafhrd91
Copy link
Member

fafhrd91 commented Apr 5, 2017

@popravich I am planing to release 2.0.6, if you want to add this to it, just cherry pick you changes into 2.0 branch

@popravich
Copy link
Member Author

ok, will do

@popravich
Copy link
Member Author

done

@fafhrd91
Copy link
Member

fafhrd91 commented Apr 5, 2017

thanks

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants