Remove Content-Length when you enable chunked encoding #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensure that no content lenght header remain after you enable chunked.
|
This have to be exception. This is mistake to supply content-length and enable chunking. |
|
I believe Content-Length header is already removed in _start method. |
|
I will make more tests in order to understand why we have content length
set to zero even if we didn't set it.
Which exception should be raise ?
Le mer. 31 mai 2017 à 09:56, Hu Bo <notifications@github.com> a écrit :
… I believe Content-Length header is already removed in *_start* method.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1933 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVFXQ6BlgwTWYedPHBnHgG8CkdNqpxjks5r_R0OgaJpZM4NqIEw>
.
|
|
|
|
I will do it in the coming day. Against 2.0 branch or master?
Le mer. 31 mai 2017 à 20:39, Andrew Svetlov <notifications@github.com> a
écrit :
… RuntimeError is enough I guess.
@noplay <https://github.com/noplay> would you create a PR for this fix?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1933 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVFXSw6V8z0Ac0n3bSddHdjsv2Gcv2Nks5r_bPMgaJpZM4NqIEw>
.
|
|
Against master |
This was referenced Jun 1, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensure that no content lenght header remain after you enable
chunked.
What do these changes do?
Remove Content-Length when you enable chunked encoding
This ensure that no content lenght header remain after you enable chunked.
Are there changes in behavior for the user?
No Content-Length will be send when you have enable chunked encoding
Related issue number
No issue
Checklist
CONTRIBUTORS.txtCHANGES.rst#issue_numberformat at the end of changelog message. Use Pull Request number if there are no issues for PR or PR covers the issue only partially.