Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

negative test for loop.run_until_complete(ClientSession().close()) deprecation warning #2077

Closed

Conversation

litwisha
Copy link
Contributor

@litwisha litwisha commented Jul 11, 2017

What do these changes do?

Shows that loop.run_until_complete(ClientSession().close()) raises DeprecationWarning.

Related issue number

#2065

Checklist

  • I think the code is well written
  • Unit tests for the changes exist

@litwisha
Copy link
Contributor Author

note: repeatable for py35+

@codecov-io
Copy link

codecov-io commented Jul 11, 2017

Codecov Report

Merging #2077 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2077   +/-   ##
=======================================
  Coverage   97.08%   97.08%           
=======================================
  Files          38       38           
  Lines        7689     7689           
  Branches     1344     1344           
=======================================
  Hits         7465     7465           
  Misses        102      102           
  Partials      122      122

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ecb633...00c8638. Read the comment docs.

@asvetlov
Copy link
Member

Hmm. I cannot reproduce the issue on Python 3.5.3 and 3.6.1, your test doesn't fail.
On other hand we could override _CoroGuard.send() if needed.
Let's discuss it tomorrow offline.

@asvetlov
Copy link
Member

asvetlov commented Aug 3, 2017

Superseded by #2161

@asvetlov asvetlov closed this Aug 3, 2017
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants