Deprecated BaseRequest.has_body, replaced with 2 new attributes (#2005) #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2169 +/- ##
==========================================
+ Coverage 97.12% 97.12% +<.01%
==========================================
Files 39 39
Lines 7848 7884 +36
Branches 1360 1366 +6
==========================================
+ Hits 7622 7657 +35
Misses 101 101
- Partials 125 126 +1
Continue to review full report at Codecov.
|
asvetlov
requested changes
Aug 5, 2017
| warnings.warn( | ||
| "Deprecated, use .can_read_body #2005", | ||
| DeprecationWarning, stacklevel=2) | ||
| return not self._payload.at_eof() |
There was a problem hiding this comment.
Added old attr back into test cases - is this okay or should I break it out into another test case?
asvetlov
approved these changes
Aug 7, 2017
|
thanks |
arthurdarcet
pushed a commit
to arthurdarcet/aiohttp
that referenced
this pull request
Aug 8, 2017
…libs#2005) (aio-libs#2169) * Deprecated BaseRequest.has_body, replaced with 2 new attributes * Test obsolete BaseRequest.has_body attr
psf-chronographer
bot
added
the
bot:chronographer:provided
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2005
of the request