Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globally exclude *.so and *.pyd files from dist #2427

Merged
merged 1 commit into from
Oct 28, 2017

Conversation

webknjaz
Copy link
Member

Fixes #2414.

P.S. I still feel the need to properly configure setuptools-git to avoid need to track files manually.

@webknjaz webknjaz added the bug label Oct 28, 2017
@webknjaz webknjaz self-assigned this Oct 28, 2017
@webknjaz webknjaz requested a review from asvetlov October 28, 2017 13:55
@codecov-io
Copy link

codecov-io commented Oct 28, 2017

Codecov Report

Merging #2427 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2427   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files          39       39           
  Lines        8153     8153           
  Branches     1419     1419           
=======================================
  Hits         7924     7924           
  Misses         99       99           
  Partials      130      130

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39f0498...5ded57e. Read the comment docs.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@asvetlov
Copy link
Member

The tricky thing about setuptools-git integration is inclusion of generated *.c files for Cython extensions.

@webknjaz
Copy link
Member Author

@asvetlov those could be easily included via setup.py

@webknjaz webknjaz merged commit 46123bd into master Oct 28, 2017
@asvetlov asvetlov deleted the bugfix/distribution-manifest branch January 11, 2018 20:26
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails on Alpine when building in not a x86 architecture
3 participants