Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FAQ #2471

Merged
merged 2 commits into from
Nov 7, 2017
Merged

Update FAQ #2471

merged 2 commits into from
Nov 7, 2017

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 6, 2017

Reflect the fact that aiohttp supports route decorators now.

kxepal
kxepal previously approved these changes Nov 6, 2017
@codecov-io
Copy link

codecov-io commented Nov 6, 2017

Codecov Report

Merging #2471 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2471   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files          39       39           
  Lines        8127     8127           
  Branches     1419     1419           
=======================================
  Hits         7895     7895           
  Misses        101      101           
  Partials      131      131

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b34a8f...a7e34c7. Read the comment docs.

@socketpair
Copy link
Contributor

Please add since which version it works.

@asvetlov
Copy link
Member Author

asvetlov commented Nov 6, 2017

@socketpair done

@socketpair
Copy link
Contributor

socketpair commented Nov 6, 2017

Is it possible to use this decorator on top of View (http://aiohttp.readthedocs.io/en/stable/web_reference.html#view) ?

I think, it should be mentioned in both, FAQ and main doc (http://aiohttp.readthedocs.io/en/stable/web_reference.html#routetabledef). (I'm going to use it, I still did not test)

@asvetlov
Copy link
Member Author

asvetlov commented Nov 6, 2017

Views are not supported (yet), PR is welcome!

@socketpair
Copy link
Contributor

So, it will be nice to mention, that Views are not supported yet.

@asvetlov
Copy link
Member Author

asvetlov commented Nov 7, 2017

I hope somebody will find a time for #2472 before 3.0
Let me merge as is.

@asvetlov asvetlov merged commit 2f3b9ce into master Nov 7, 2017
@asvetlov asvetlov deleted the update-faq branch November 7, 2017 09:08
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants