Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await in websockets #2475

Merged
merged 4 commits into from
Nov 7, 2017
Merged

Await in websockets #2475

merged 4 commits into from
Nov 7, 2017

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 7, 2017

Make send_*() and ping()/pong() true coroutines.

Get rid of yield from

@codecov-io
Copy link

codecov-io commented Nov 7, 2017

Codecov Report

Merging #2475 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2475      +/-   ##
==========================================
- Coverage   97.14%   97.14%   -0.01%     
==========================================
  Files          39       39              
  Lines        8127     8125       -2     
  Branches     1419     1419              
==========================================
- Hits         7895     7893       -2     
  Misses        101      101              
  Partials      131      131
Impacted Files Coverage Δ
aiohttp/payload_streamer.py 100% <ø> (ø) ⬆️
aiohttp/http_writer.py 94.44% <100%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 132495a...eb06758. Read the comment docs.

@asvetlov
Copy link
Member Author

asvetlov commented Nov 7, 2017

Need a doc update before merging

@asvetlov asvetlov merged commit c29b630 into master Nov 7, 2017
@asvetlov asvetlov deleted the await-in-websockets branch November 7, 2017 17:38
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants