-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix async with in TestClient.ws_connect #2528
Conversation
0969027
to
8b28ac9
Compare
Issue numbers in titles don't work as links and generally don't mean much to people. Best to use a short descriptive title and add the issue number to the body. |
Thanks, should be more expressive now. |
The change looks good but worth for a new test for added functionality. |
Codecov Report
@@ Coverage Diff @@
## master #2528 +/- ##
==========================================
+ Coverage 97.13% 97.13% +<.01%
==========================================
Files 39 39
Lines 8068 8070 +2
Branches 1415 1415
==========================================
+ Hits 7837 7839 +2
Misses 99 99
Partials 132 132
Continue to review full report at Codecov.
|
thanks! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs. |
What do these changes do?
Add async with support for TestClient.ws_connect
Are there changes in behavior for the user?
No
Related issue number
#2525
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bug)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.