Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amends 4ce3c4a sending the chunk signal by write_eof equal than write #2913

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Amends 4ce3c4a sending the chunk signal by write_eof equal than write #2913

merged 1 commit into from
Apr 5, 2018

Conversation

pfreixes
Copy link
Contributor

@pfreixes pfreixes commented Apr 4, 2018

What do these changes do?

Amends 4ce3c4a sending the chunk signal by write_eof equal than write

Related issue number

#2911

@pfreixes
Copy link
Contributor Author

pfreixes commented Apr 4, 2018

@asvetlov && @vasilenkoalexey ^^

@codecov-io
Copy link

codecov-io commented Apr 4, 2018 •
edited
Loading

Codecov Report

Merging #2913 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2913   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files          40       40           
  Lines        7508     7508           
  Branches     1317     1317           
=======================================
  Hits         7357     7357           
  Misses         48       48           
  Partials      103      103
Impacted Files Coverage Δ
aiohttp/http_writer.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6ab7d...d83cadc. Read the comment docs.

vasilenkoalexey
vasilenkoalexey approved these changes Apr 4, 2018
View reviewed changes
Copy link

@vasilenkoalexey vasilenkoalexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@pfreixes
Copy link
Contributor Author

pfreixes commented Apr 4, 2018

let's wait for the @asvetlov approval and I will make the backport to the 3.1 by hand.

@asvetlov
Copy link
Member

asvetlov commented Apr 5, 2018

LGTM

@pfreixes pfreixes merged commit c5d3999 into master Apr 5, 2018
pfreixes added a commit that referenced this pull request Apr 5, 2018
@pfreixes
Amends 4ce3c4a sending the chunk signal by write_eof equal than write (…
21773ca 
…#2913)

(cherry picked from commit c5d3999)
pfreixes added a commit that referenced this pull request Apr 5, 2018
@pfreixes
Backport 6a6ab7d and c5d399 to 3.1 (#2915)
db7dcb8 
* Call on_chunk_sent when write_eof is called with a valid chunk (#2911)

(cherry picked from commit 6a6ab7d)

* Amends 4ce3c4a sending the chunk signal by write_eof equal than write (#2913)

(cherry picked from commit c5d3999)
@asvetlov asvetlov deleted the on_chunk_sent_aligned branch September 7, 2019 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasilenkoalexey vasilenkoalexey vasilenkoalexey approved these changes

@asvetlov asvetlov asvetlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pfreixes @codecov-io @asvetlov @vasilenkoalexey