Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encourage creation of aiohttp objects from coroutines #3372

Merged
merged 9 commits into from
Oct 30, 2018
Merged

Encourage creation of aiohttp objects from coroutines #3372

merged 9 commits into from
Oct 30, 2018

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Oct 30, 2018 •
edited
Loading

Fixes #3331

@asvetlov asvetlov requested a review from webknjaz as a code owner October 30, 2018 17:39
@aio-libs-bot aio-libs-bot added the good first issue Good for newcomers label Oct 30, 2018
@kxepal
Copy link
Member

kxepal commented Oct 30, 2018

This wouldn't affect creation of web.Application object, right?

@asvetlov
Copy link
Member Author

In web.Application loop parameter is deprecated already.

@kxepal
Copy link
Member

kxepal commented Oct 30, 2018

Ah, right. Thanks!

@asvetlov asvetlov merged commit 889b186 into master Oct 30, 2018
@asvetlov asvetlov deleted the encourage-coroutine branch October 30, 2018 23:00
@thanosexcite thanosexcite mentioned this pull request Dec 24, 2018
Closed
@lock
Copy link

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR good first issue Good for newcomers outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encourage creation of aiohttp public objects inside a coroutine
3 participants
@asvetlov @kxepal @aio-libs-bot