-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the behavior of url dispatching with quote characters. #414
Change the behavior of url dispatching with quote characters. #414
Conversation
""" | ||
return self._splitted_path.path | ||
|
||
@property |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use @reofy
instead of @property
Please fix my inline notes and add doc for |
I'm not sure we want to make this behavior the default one and according to #351 (comment) it's the RFC behavior that we may want to make the default one. I will fix the other notes. |
@kxepal would you join to discussion?
Does my proposal make sense? |
@asvetlov absolutely. +1 for that. |
@@ -1,3 +1,11 @@ | |||
0.17.0 (XX-XX-XXXX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to modify CHANGES.rst instead. 0.17.0 is an upcoming release, not the archived one.
b59af6e
to
003c4ad
Compare
I've made the changes and update the commit message + PR description. |
The quoted characters of the URL will not be significant during url dispatching but will be decoded after the matching. For example, with this route: ``` @asyncio.coroutine def handler(request): return web.Response(body=repr(request.match_info)) app = Application(loop=loop) app.router.add_route('GET', '/{route}', handler) ``` The following query will generate this match_info: ``` curl -I http://127.0.0.1:8080/route%2Fslash HTTP/1.1 200 OK ... <MatchInfo {'route': 'route/slash'}: <DynamicRoute [*] /{route} -> <function handler at 0x10b888158>> ```
003c4ad
to
2f1d33c
Compare
Thanks |
The quoted characters of the URL will not be significant during url dispatching
but will be decoded after the matching.
For example, with this route:
The following query will generate this match_info: