Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid putting a new connection in the free list #471

Closed

Conversation

mpaolini
Copy link
Contributor

The invariant should be: a transport is either in the free list (_conns)
or in the active list (_acquired).

This fixes a bug that put every newly created connection in both lists

The invariant should be: a transport is either in the free list (_conns)
or in the active list (_acquired).

This fixes a bug that put every newly created connection in both lists
@mpaolini
Copy link
Contributor Author

basically I am reverting the changes made in #406 ... but the tests still pass

@mpaolini mpaolini mentioned this pull request Aug 22, 2015
@mpaolini
Copy link
Contributor Author

superseded by #473 . Maybe this can be closed

@mpaolini mpaolini closed this Aug 23, 2015
@lock
Copy link

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant