Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] Eliminate side-effects from the ClientResponse.ok property #5407

Merged
merged 1 commit into from
Feb 1, 2021
Merged

[3.8] Eliminate side-effects from the ClientResponse.ok property #5407

merged 1 commit into from
Feb 1, 2021

Commits on Jan 14, 2021

  1. [3.8] Eliminate side-effects from the ClientResponse.ok property

    This change makes it so accessing `ClientResponse.ok` only does the status
    code check.
    
    Prior to this commit, it'd call `ClientResponse.raise_for_status()` which
    in turn, closed the underlying TCP session whenever the status was 400 or
    higher making it effectively impossible to keep working with the response,
    including reading the HTTP response payload.
    
    PR #5404 by @adamko147
    
    Fixes #5403
    
    Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>
    (cherry picked from commit 3250c5d)
    
    Co-authored-by: Adam Horacek <adam.horacek@gmail.com>
    adamko147 committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    5335bc6 View commit details
    Browse the repository at this point in the history