Patchback/backports/3.9/e5beaca052434cbf1c1814170917085eb271ba43/pr 3892 implement response check #6731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement response check, aio-libs#3864 * switch to raise_for_status coroutine * fix linting * revert name corrections * fix types, add request tests * change and docs * allow non callable truey raise_for_status (cherry picked from commit e5beaca)
psf-chronographer
bot
added
the
bot:chronographer:provided
for more information, see https://pre-commit.ci
|
Looks like the noqa is not needed. Looks good to me once the pre-commit passes. Thanks. |
auto-merge was automatically disabled
May 2, 2022 22:37
Head branch was pushed to by a user without write access
arjd
deleted the
patchback/backports/3.9/e5beaca052434cbf1c1814170917085eb271ba43/pr-3892
branch
|
@arjd the world thanks you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Backport for #3892, which allowed
raise_for_statusto optionally be a coroutine.Are there changes in behavior for the user?
Should be fully backwards-compatible.
Related issue number
#3892
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.