Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #271: Memory leak in request #723

Merged
merged 1 commit into from
Jan 7, 2016
Merged

Fix #271: Memory leak in request #723

merged 1 commit into from
Jan 7, 2016

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jan 7, 2016

No description provided.

@fafhrd91
Copy link
Member

fafhrd91 commented Jan 7, 2016

why do you think add_headers() is the problem?

@asvetlov
Copy link
Member Author

asvetlov commented Jan 7, 2016

It is not add_headers() actually but generator unpacking.
See https://gist.github.com/asvetlov/227af16ae9eb38db7f22
We discovered the issue with @mpaolini last night.

Regarding to add_headers() -- it's just extra call which doesn't make any additional value.

@fafhrd91
Copy link
Member

fafhrd91 commented Jan 7, 2016

ok, i see.

asvetlov added a commit that referenced this pull request Jan 7, 2016
@asvetlov
Merge pull request #723 from KeepSafe/fix_memleak
ce89d36 
Fix #271: Memory leak in request
@asvetlov asvetlov merged commit ce89d36 into 0.20 Jan 7, 2016
@asvetlov asvetlov mentioned this pull request Jan 7, 2016
Closed
@asvetlov asvetlov deleted the fix_memleak branch January 7, 2016 21:52
@kxepal
Copy link
Member

kxepal commented Jan 7, 2016

@asvetlov Nice found! Is that CIMultiDict specific or general generator unpacking issue don't you know?

@asvetlov
Copy link
Member Author

asvetlov commented Jan 7, 2016

It's python unpacking issue.
Reproducible with any structure (dict, list, etc.).
I'm trying to investigate and maybe create a patch.

@mpaolini
Copy link
Contributor

mpaolini commented Jan 7, 2016

It did fix the leak that has been going on on my side since v0.14.0 at least. Thanks @asvetlov

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asvetlov @fafhrd91 @kxepal @mpaolini