Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #7316

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Update docs #7316

merged 1 commit into from
Jun 9, 2023

Conversation

serhii73
Copy link
Contributor

@serhii73 serhii73 commented Jun 9, 2023

Call main() does not returns any loop. Close #7314

@serhii73
Update docs
cd15622 
Call main() does not returns any loop. Close aio-libs#7314
@webknjaz webknjaz added bot:chronographer:skip This PR does not need to include a change note backport-3.8 labels Jun 9, 2023
@codecov
Copy link

codecov bot commented Jun 9, 2023 •
edited
Loading

Codecov Report

Merging #7316 (cd15622) into master (2843883) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7316   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files         106      106           
  Lines       31456    31456           
  Branches     3940     3940           
=======================================
  Hits        30608    30608           
  Misses        644      644           
  Partials      204      204
Flag Coverage Δ
CI-GHA 97.21% <ø> (ø)
OS-Linux 96.87% <ø> (ø)
OS-Windows 95.34% <ø> (ø)
OS-macOS 96.47% <ø> (-0.01%) ⬇️
Py-3.10.11 96.98% <ø> (ø)
Py-3.11.0 96.42% <ø> (ø)
Py-3.7.16 96.70% <ø> (ø)
Py-3.7.9 95.21% <ø> (ø)
Py-3.8.10 95.13% <ø> (ø)
Py-3.8.16 96.61% <ø> (ø)
Py-3.9.13 95.13% <ø> (ø)
Py-3.9.16 96.63% <ø> (-0.01%) ⬇️
Py-pypy7.3.11 94.11% <ø> (-0.01%) ⬇️
VM-macos 96.47% <ø> (-0.01%) ⬇️
VM-ubuntu 96.87% <ø> (ø)
VM-windows 95.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer
Copy link
Member

Thanks.
There's a couple of run_until_complete() calls in testing.md as well, but might need some different changes (I'm not clear exactly what loop_context() is for in that documentation).

@Dreamsorcerer Dreamsorcerer merged commit 6f3e7f4 into aio-libs:master Jun 9, 2023
@patchback
Copy link
Contributor

patchback bot commented Jun 9, 2023 •
edited
Loading

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/6f3e7f4687089ecb085a49aadbe372e5408fb9bb/pr-7316

Backported as #7317

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 9, 2023
@serhii73 @patchback
Update docs (#7316)
acfce80 
Call main() does not returns any loop. Close #7314

(cherry picked from commit 6f3e7f4)
@patchback patchback bot mentioned this pull request Jun 9, 2023
Merged
@patchback
Copy link
Contributor

patchback bot commented Jun 9, 2023 •
edited
Loading

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/6f3e7f4687089ecb085a49aadbe372e5408fb9bb/pr-7316

Backported as #7318

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jun 9, 2023
@serhii73 @patchback
Update docs (#7316)
a1ab040 
Call main() does not returns any loop. Close #7314

(cherry picked from commit 6f3e7f4)
@patchback patchback bot mentioned this pull request Jun 9, 2023
Merged
Dreamsorcerer pushed a commit that referenced this pull request Jun 9, 2023
@patchback @serhii73
[PR #7316/6f3e7f46 backport][3.8] Update docs (#7317)
81ba8aa 
**This is a backport of PR #7316 as merged into master
(6f3e7f4).**

Call main() does not returns any loop. Close #7314

Co-authored-by: Serhii A <aserhii@protonmail.com>
Dreamsorcerer pushed a commit that referenced this pull request Jun 9, 2023
@patchback @serhii73
[PR #7316/6f3e7f46 backport][3.9] Update docs (#7318)
f1885ff 
**This is a backport of PR #7316 as merged into master
(6f3e7f4).**

Call main() does not returns any loop. Close #7314

Co-authored-by: Serhii A <aserhii@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.10 - DeprecationWarning on example "Run a Basic Low-Level Server"
3 participants
@serhii73 @Dreamsorcerer @webknjaz