Retry connection

[Dreamsorcerer]

Fixes #7297.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fde452d) 97.30% compared to head (bd04e03) 97.48%.
Report is 468 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7363      +/-   ##
==========================================
+ Coverage   97.30%   97.48%   +0.18%     
==========================================
  Files         106      107       +1     
  Lines       31456    32601    +1145     
  Branches     3940     3799     -141     
==========================================
+ Hits        30608    31782    +1174     
+ Misses        644      616      -28     
+ Partials      204      203       -1     

Flag	Coverage Δ
CI-GHA	97.40% <100.00%> (+0.19%)	⬆️
OS-Linux	97.07% <100.00%> (+0.19%)	⬆️
OS-Windows	95.57% <100.00%> (+0.23%)	⬆️
OS-macOS	96.89% <100.00%> (+0.42%)	⬆️
Py-3.10.11	95.50% <100.00%> (-1.49%)	⬇️
Py-3.10.13	96.87% <100.00%> (?)
Py-3.11.0	?
Py-3.11.7	96.56% <100.00%> (?)
Py-3.12.1	96.69% <100.00%> (?)
Py-3.7.16	?
Py-3.7.9	?
Py-3.8.10	95.47% <100.00%> (+0.33%)	⬆️
Py-3.8.16	?
Py-3.8.18	96.81% <100.00%> (?)
Py-3.9.13	95.47% <100.00%> (+0.34%)	⬆️
Py-3.9.16	?
Py-3.9.18	96.85% <100.00%> (?)
Py-pypy7.3.11	?
Py-pypy7.3.15	96.40% <100.00%> (?)
VM-macos	96.89% <100.00%> (+0.42%)	⬆️
VM-ubuntu	97.07% <100.00%> (+0.19%)	⬆️
VM-windows	95.57% <100.00%> (+0.23%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bdraco]

I think this is a good solution. This problem comes up all the time with new libraries in Home Assistant.

The downside is that there will already be downstream retry code so it may get retried once more downstream again. I don't think thats a blocker, but its probably important to highlight that downstream retry code should be removed

[Dreamsorcerer]

The downside is that there will already be downstream retry code so it may get retried once more downstream again. I don't think thats a blocker, but its probably important to highlight that downstream retry code should be removed

Sure, though we only retry once. I think custom retry logic often has multiple retries, so some may want to keep it anyway.

[bdraco]

The downside is that there will already be downstream retry code so it may get retried once more downstream again. I don't think thats a blocker, but its probably important to highlight that downstream retry code should be removed

Sure, though we only retry once. I think custom retry logic often has multiple retries, so some may want to keep it anyway.

It looks like all the ones HA has done only retry once as well. So now they will retry twice. I think this is acceptable risk.

[bdraco]

LGTM, only outstanding comment from me is the set constant

[patchback]

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply be9a3cc on top of patchback/backports/3.10/be9a3cc9b3e617cb146093df6e05a73258aedb39/pr-7363

Backporting merged PR #7363 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/aio-libs/aiohttp.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/3.10/be9a3cc9b3e617cb146093df6e05a73258aedb39/pr-7363 upstream/3.10

4. Now, cherry-pick PR Retry connection #7363 contents into that branch:

   $ git cherry-pick -x be9a3cc9b3e617cb146093df6e05a73258aedb39

   If it'll yell at you with something like fatal: Commit be9a3cc9b3e617cb146093df6e05a73258aedb39 is a merge but no -m option was given., add -m 1 as follows instead:

   $ git cherry-pick -m1 -x be9a3cc9b3e617cb146093df6e05a73258aedb39

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Retry connection #7363 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/3.10/be9a3cc9b3e617cb146093df6e05a73258aedb39/pr-7363

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.