-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry connection #7363
Retry connection #7363
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7363 +/- ##
==========================================
+ Coverage 97.30% 97.48% +0.18%
==========================================
Files 106 107 +1
Lines 31456 32601 +1145
Branches 3940 3799 -141
==========================================
+ Hits 30608 31782 +1174
+ Misses 644 616 -28
+ Partials 204 203 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think this is a good solution. This problem comes up all the time with new libraries in Home Assistant. The downside is that there will already be downstream retry code so it may get retried once more downstream again. I don't think thats a blocker, but its probably important to highlight that downstream retry code should be removed |
Sure, though we only retry once. I think custom retry logic often has multiple retries, so some may want to keep it anyway. |
It looks like all the ones HA has done only retry once as well. So now they will retry twice. I think this is acceptable risk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only outstanding comment from me is the set
constant
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply be9a3cc on top of patchback/backports/3.10/be9a3cc9b3e617cb146093df6e05a73258aedb39/pr-7363 Backporting merged PR #7363 into master
🤖 @patchback |
Fixes #7297.