Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump charset-normalizer from 2.0.12 to 3.2.0 #7389

Merged
merged 4 commits into from
Jul 29, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 20, 2023

Bumps charset-normalizer from 2.0.12 to 3.2.0.

Release notes

Sourced from charset-normalizer's releases.

Version 3.2.0

3.2.0 (2023-06-07)

Changed

  • Typehint for function from_path no longer enforce PathLike as its first argument
  • Minor improvement over the global detection reliability

Added

  • Introduce function is_binary that relies on main capabilities, and is optimized to detect binaries
  • Propagate enable_fallback argument throughout from_bytes, from_path, and from_fp that allow a deeper control over the detection (default True)
  • Explicit support for Python 3.12

Fixed

  • Edge case detection failure where a file would contain 'very-long' camel-cased word (Issue #289)

Version 3.1.0

3.1.0 (2023-03-06)

Added

  • Argument should_rename_legacy for legacy function detect and disregard any new arguments without errors (PR #262)

Removed

  • Support for Python 3.6 (PR #260)

Changed

  • Optional speedup provided by mypy/c 1.0.1

Version 3.0.1

3.0.1 (2022-11-18)

Fixed

  • Multi-bytes cutter/chunk generator did not always cut correctly (PR #233)

Changed

  • Speedup provided using mypy/c 0.990 on Python >= 3.7

Version 3.0.0

3.0.0 (2022-10-20)

Added

  • Extend the capability of explain=True when cp_isolation contains at most two entries (min one), will log in details of the Mess-detector results
  • Support for alternative language frequency set in charset_normalizer.assets.FREQUENCIES
  • Add parameter language_threshold in from_bytes, from_path and from_fp to adjust the minimum expected coherence ratio
  • normalizer --version now specify if the current version provides extra speedup (meaning mypyc compilation whl)

Changed

  • Build with static metadata (not pyproject.toml yet)
  • Make language detection stricter
  • Optional: Module md.py can be compiled using Mypyc to provide an extra speedup up to 4x faster than v2.1

... (truncated)

Changelog

Sourced from charset-normalizer's changelog.

3.2.0 (2023-06-07)

Changed

  • Typehint for function from_path no longer enforce PathLike as its first argument
  • Minor improvement over the global detection reliability

Added

  • Introduce function is_binary that relies on main capabilities, and optimized to detect binaries
  • Propagate enable_fallback argument throughout from_bytes, from_path, and from_fp that allow a deeper control over the detection (default True)
  • Explicit support for Python 3.12

Fixed

  • Edge case detection failure where a file would contain 'very-long' camel cased word (Issue #289)

3.1.0 (2023-03-06)

Added

  • Argument should_rename_legacy for legacy function detect and disregard any new arguments without errors (PR #262)

Removed

  • Support for Python 3.6 (PR #260)

Changed

  • Optional speedup provided by mypy/c 1.0.1

3.0.1 (2022-11-18)

Fixed

  • Multi-bytes cutter/chunk generator did not always cut correctly (PR #233)

Changed

  • Speedup provided by mypy/c 0.990 on Python >= 3.7

3.0.0 (2022-10-20)

Added

  • Extend the capability of explain=True when cp_isolation contains at most two entries (min one), will log in details of the Mess-detector results
  • Support for alternative language frequency set in charset_normalizer.assets.FREQUENCIES
  • Add parameter language_threshold in from_bytes, from_path and from_fp to adjust the minimum expected coherence ratio
  • normalizer --version now specify if current version provide extra speedup (meaning mypyc compilation whl)

Changed

  • Build with static metadata using 'build' frontend
  • Make the language detection stricter
  • Optional: Module md.py can be compiled using Mypyc to provide an extra speedup up to 4x faster than v2.1

Fixed

  • CLI with opt --normalize fail when using full path for files
  • TooManyAccentuatedPlugin induce false positive on the mess detection when too few alpha character have been fed to it
  • Sphinx warnings when generating the documentation

... (truncated)

Upgrade guide

Sourced from charset-normalizer's upgrade guide.

Guide to upgrade your code from v1 to v2

  • If you are using the legacy detect function, that is it. You have nothing to do.

Detection

Before

from charset_normalizer import CharsetNormalizerMatches
results = CharsetNormalizerMatches.from_bytes(
'我没有埋怨,磋砣的只是一些时间。'.encode('utf_32')
)

After

from charset_normalizer import from_bytes
results = from_bytes(
'我没有埋怨,磋砣的只是一些时间。'.encode('utf_32')
)

Methods that once were staticmethods of the class CharsetNormalizerMatches are now basic functions. from_fp, from_bytes, from_fp and `` are concerned.

Staticmethods scheduled to be removed in version 3.0

Commits
  • 0424c80 Add workflow_call for ci.yml workflow (reusable) (#307)
  • 782885e Fix issue 289, add function is_binary, add explicit support py 3.12 (#306)
  • 1b0fb5c ⬆️ Bump pytest from 7.3.2 to 7.4.0 (#304)
  • 3acf08e ⬆️ Bump mypy from 1.3.0 to 1.4.1 (#305)
  • 5c030b5 Replace emoji shortcodes with UTF-8 emoji (#303)
  • f9f686b ⬆️ Bump pypa/cibuildwheel from 2.13.0 to 2.13.1 (#302)
  • d42cdaf ⬆️ Bump slsa-framework/slsa-github-generator from 1.6.0 to 1.7.0 (#301)
  • f8e7db1 ⬆️ Bump pytest from 7.3.1 to 7.3.2 (#300)
  • 6f02962 ⬆️ Bump pytest-cov from 4.0.0 to 4.1.0 (#298)
  • 8028c56 ⬆️ Bump pypa/cibuildwheel from 2.12.3 to 2.13.0 (#299)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jul 20, 2023
@github-actions github-actions bot enabled auto-merge (squash) July 20, 2023 10:28
@dependabot dependabot bot force-pushed the dependabot/pip/3.9/charset-normalizer-3.2.0 branch from 551a42f to 90b73f3 Compare July 25, 2023 19:08
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #7389 (7afaa2a) into 3.9 (38ffe6f) will increase coverage by 0.36%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              3.9    #7389      +/-   ##
==========================================
+ Coverage   96.91%   97.28%   +0.36%     
==========================================
  Files         107      107              
  Lines       31617    31617              
  Branches     3655     3655              
==========================================
+ Hits        30643    30758     +115     
+ Misses        759      653     -106     
+ Partials      215      206       -9     
Flag Coverage Δ
CI-GHA 97.22% <ø> (+0.34%) ⬆️
OS-Linux 96.91% <ø> (+0.05%) ⬆️
OS-Windows 94.53% <ø> (?)
OS-macOS 96.58% <ø> (+0.09%) ⬆️
Py-3.10.11 94.44% <ø> (?)
Py-3.10.12 96.78% <ø> (+<0.01%) ⬆️
Py-3.11.4 96.52% <ø> (-0.01%) ⬇️
Py-3.8.10 94.41% <ø> (?)
Py-3.8.17 96.72% <ø> (ø)
Py-3.9.13 94.42% <ø> (?)
Py-3.9.17 96.76% <ø> (+0.02%) ⬆️
Py-pypy7.3.11 96.31% <ø> (?)
VM-macos 96.58% <ø> (+0.09%) ⬆️
VM-ubuntu 96.91% <ø> (+0.05%) ⬆️
VM-windows 94.53% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Dreamsorcerer
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 26, 2023

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@Dreamsorcerer
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/pip/3.9/charset-normalizer-3.2.0 branch from 95e9e42 to 55aeaa1 Compare July 26, 2023 09:54
@Dreamsorcerer
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/pip/3.9/charset-normalizer-3.2.0 branch 3 times, most recently from 1eb70cb to b28e772 Compare July 27, 2023 19:13
@Dreamsorcerer
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/pip/3.9/charset-normalizer-3.2.0 branch from b28e772 to 580b7b8 Compare July 27, 2023 19:42
@Dreamsorcerer
Copy link
Member

@dependabot recreate

Bumps [charset-normalizer](https://github.com/Ousret/charset_normalizer) from 2.0.12 to 3.2.0.
- [Release notes](https://github.com/Ousret/charset_normalizer/releases)
- [Changelog](https://github.com/Ousret/charset_normalizer/blob/master/CHANGELOG.md)
- [Upgrade guide](https://github.com/Ousret/charset_normalizer/blob/master/UPGRADE.md)
- [Commits](jawah/charset_normalizer@2.0.12...3.2.0)

---
updated-dependencies:
- dependency-name: charset-normalizer
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pip/3.9/charset-normalizer-3.2.0 branch from 8d5c8f3 to eee2b8e Compare July 28, 2023 00:16
@Dreamsorcerer
Copy link
Member

@webknjaz This one seems to be failing because requests is out of date. Shouldn't dependabot be bumping the dependencies in constraints.txt?

@webknjaz
Copy link
Member

@Dreamsorcerer dependabot only bumps file pairs in+txt. But if there's just one, it doesn't normally.

@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Jul 28, 2023

I'm just not clear how Dependabot sees constraints.txt and base.txt as any different. They both are .txt files containing a list of package versions.

I can see setuptools is outdated too, and that might be causing one of 3.12 failures. Going to be a bit annoying if Dependabot never updates any of these...

@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Jul 28, 2023

Hmm, I found this issue (one of yours), but the comment at the end suggests that including -c constraints.txt within the requirements file might help Dependabot. Though I'm unclear precisely what it will change (maybe eliminate the need for the post-dependabot job?):
dependabot/dependabot-core#2272 (comment)

There is also this issue suggesting the behaviour of which files it uses has changed recently, and it was updating constraints.txt until a couple of months ago:
dependabot/dependabot-core#7253
And we can see some of our previous PRs were bumping that file too (edit: I think it's just security updates actually, which only run on master): #7382

@github-actions github-actions bot merged commit 19760db into 3.9 Jul 29, 2023
21 of 26 checks passed
@github-actions github-actions bot deleted the dependabot/pip/3.9/charset-normalizer-3.2.0 branch July 29, 2023 13:39
@webknjaz
Copy link
Member

Though I'm unclear precisely what it will change

It'll just apply extra pre-defined limitations. Dependabot used to have a bug with this, though. Dunno if it's fixed as of today..

(maybe eliminate the need for the post-dependabot job?)

This would require some restructuring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants