-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support passing a custom server name parameter on HTTPS connection #7543
Support passing a custom server name parameter on HTTPS connection #7543
Conversation
…io-libs#7541) This adds the missing support to set the `server_hostname` setting when creating TCP connection, when the underlying connection is authenticated using TLS. See the documentation for the 2 stdlib functions: * https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.create_connection * https://docs.python.org/3/library/asyncio-eventloop.html#opening-network-connections This would be needed to support features in clients using aiohttp, such as tomplus/kubernetes_asyncio#267 The default behavior should not change, but this would allow on a per-connection basis to specify a custom server name to check the certificate name against. Closes: aio-libs#7114 (for reference, similar implementation in urllib3: urllib3/urllib3#1397) - [x] I think the code is well written - [x] Unit tests for the changes exist - [x] Documentation reflects the changes - [x] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [x] Add a new news fragment into the `CHANGES` folder * name it `<issue_id>.<type>` for example (588.bugfix) * if you don't have an `issue_id` change it to the pr id after creating the pr * ensure type is one of the following: * `.feature`: Signifying a new feature. * `.bugfix`: Signifying a bug fix. * `.doc`: Signifying a documentation improvement. * `.removal`: Signifying a deprecation or removal of public API. * `.misc`: A ticket has been closed, but it is not of interest to users. * Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files." --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sam Bull <aa6bs0@sambull.org> (cherry picked from commit ac29dea)
Codecov Report
@@ Coverage Diff @@
## 3.9 #7543 +/- ##
=======================================
Coverage 97.29% 97.30%
=======================================
Files 107 107
Lines 31628 31685 +57
Branches 3661 3667 +6
=======================================
+ Hits 30773 30830 +57
Misses 651 651
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Dreamsorcerer Do you think it would be possible to get a new 3.9 release with this fix? |
Had a couple of other priorities, but will get back to a 3.9 release soon. |
This adds the missing support to set the
server_hostname
setting when creating TCP connection, when the underlying connection is authenticated using TLS.See the documentation for the 2 stdlib functions:
This would be needed to support features in clients using aiohttp, such as tomplus/kubernetes_asyncio#267
The default behavior should not change, but this would allow on a per-connection basis to specify a custom server name to check the certificate name against.
Closes: #7114
Backport of #7541 to 3.9
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature. *.bugfix
: Signifying a bug fix. *.doc
: Signifying a documentation improvement. *.removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sam Bull aa6bs0@sambull.org
(cherry picked from commit ac29dea)