Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multipart chunk #756

Merged
merged 4 commits into from
Jan 31, 2016
Merged

Fix multipart chunk #756

merged 4 commits into from
Jan 31, 2016

Conversation

tumb1er
Copy link
Contributor

@tumb1er tumb1er commented Jan 31, 2016

In real life after #750 some issues have appeared.

  1. For small requests read_chunks reads all content till EOF, so unread_data should allow to run at eof state.
  2. If last but one chunk is incomplete (len < chunk_size), some bytes are skipped in part content.

@kxepal
Copy link
Member

kxepal commented Jan 31, 2016

LGFM, except linter assertion for tests. Could you fix it?

@tumb1er
Copy link
Contributor Author

tumb1er commented Jan 31, 2016

Fixed.

kxepal added a commit that referenced this pull request Jan 31, 2016
@kxepal
Merge pull request #756 from tumb1er/fix_multipart_chunk
0ef2382 
Fix multipart chunk
@kxepal kxepal merged commit 0ef2382 into aio-libs:master Jan 31, 2016
@kxepal
Copy link
Member

kxepal commented Jan 31, 2016

@tumb1er thanks!

@tumb1er tumb1er deleted the fix_multipart_chunk branch January 31, 2016 11:44
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tumb1er @kxepal