[backport] feature: allow link argument to be set to None/empty in HTTP 451 exception #7704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption (#7689) <!-- Thank you for your contribution! --> This PR allows for the link argument to be set to None/empty (so it can be optional) as per RFC in the HTTP 451 exception (`HTTPUnavailableForLegalReasons`). It also adds suitable unit tests for the `link` argument and aligns variable naming in the test class of this exception. I also updated the documentation for this exception and adjusted the documented signatures of the other exceptions in the same section (the `body` argument does not exist anymore). The exception constructor no longer requires the `link` argument nor accepts empty or invalid values. - [X] I think the code is well written - [X] Unit tests for the changes exist - [X] Documentation reflects the changes - [X] If you provide code modification, please add yourself to `CONTRIBUTORS.txt` * The format is <Name> <Surname>. * Please keep alphabetical order, the file is sorted by names. - [x] Add a new news fragment into the `CHANGES` folder * name it `<issue_id>.<type>` for example (588.bugfix) * if you don't have an `issue_id` change it to the pr id after creating the pr * ensure type is one of the following: * `.feature`: Signifying a new feature. * `.bugfix`: Signifying a bug fix. * `.doc`: Signifying a documentation improvement. * `.removal`: Signifying a deprecation or removal of public API. * `.misc`: A ticket has been closed, but it is not of interest to users. * Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files." --------- Co-authored-by: Sam Bull <aa6bs0@sambull.org> (cherry picked from commit d7802fe)
psf-chronographer
bot
added
the
bot:chronographer:provided
hhromic
changed the title
Codecov Report
@@ Coverage Diff @@
## 3.9 #7704 +/- ##
=======================================
Coverage 97.30% 97.31%
=======================================
Files 107 107
Lines 31857 31881 +24
Branches 3719 3722 +3
=======================================
+ Hits 31000 31024 +24
Misses 653 653
Partials 204 204
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hhromic
deleted the
patchback/backports/3.9/d7802fe2e48bd7b1f70c8d66786ad125305eaa24/pr-7689
branch
xiangxli
pushed a commit
to xiangxli/aiohttp
that referenced
this pull request
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the backport of #7689 for 3.9.
I tried to backport it as close as possible to the state of the 3.9 branch.