Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClientResponse.close releasing the connection instead of closing (#7869) #7874

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 22, 2023

(cherry picked from commit 25ef450)

@bdraco bdraco requested a review from asvetlov as a code owner November 22, 2023 19:50
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3c63ca0) 97.34% compared to head (5a2db9b) 97.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #7874   +/-   ##
=======================================
  Coverage   97.34%   97.34%           
=======================================
  Files         108      108           
  Lines       32384    32407   +23     
  Branches     3839     3843    +4     
=======================================
+ Hits        31524    31547   +23     
  Misses        655      655           
  Partials      205      205           
Flag Coverage Δ
CI-GHA 97.25% <100.00%> (+<0.01%) ⬆️
OS-Linux 96.94% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.49% <100.00%> (+<0.01%) ⬆️
OS-macOS 96.60% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 94.40% <100.00%> (+<0.01%) ⬆️
Py-3.10.13 96.78% <100.00%> (+<0.01%) ⬆️
Py-3.11.6 96.45% <100.00%> (+<0.01%) ⬆️
Py-3.8.10 94.38% <100.00%> (+<0.01%) ⬆️
Py-3.8.18 96.70% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 94.39% <100.00%> (+<0.01%) ⬆️
Py-3.9.18 96.76% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.13 96.21% <100.00%> (+<0.01%) ⬆️
VM-macos 96.60% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 96.94% <100.00%> (+<0.01%) ⬆️
VM-windows 94.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 45147c4 into aio-libs:3.10 Nov 23, 2023
26 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants