-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added server_hostname param to ws_connect method #7942
Conversation
added server_hostname param to ws_connect
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7942 +/- ##
==========================================
+ Coverage 97.36% 97.43% +0.06%
==========================================
Files 107 107
Lines 32346 32346
Branches 3748 3748
==========================================
+ Hits 31494 31516 +22
+ Misses 647 629 -18
+ Partials 205 201 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I think that looks fine to me. |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 0b71e1c on top of patchback/backports/3.10/0b71e1ce595f8ac489d13b05bc9fc468ff4250b0/pr-7942 Backporting merged PR #7942 into master
🤖 @patchback |
If you could follow the backport instructions, that'd be appreciated. |
added the server_hostname param to ws_connect method, so it will simply be passed to the _request method which already supports the server_hostname param.
Fixes #7941