[PR #8012/5f699bbb backport][3.9] Fix FileResponse doing blocking I/O in the event loop #8015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
(cherry picked from commit 5f699bb)
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.9 #8015 +/- ##
=======================================
Coverage 97.38% 97.38%
=======================================
Files 108 108
Lines 32471 32474 +3
Branches 3846 3845 -1
=======================================
+ Hits 31623 31626 +3
Misses 646 646
Partials 202 202
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bdraco
approved these changes
Jan 11, 2024
bdraco
deleted the
patchback/backports/3.9/5f699bbbf98d3700921ec9a7d646d5f21e82e8c1/pr-8012
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #8012 as merged into master (5f699bb).
What do these changes do?
Fix
FileResponsedoing blocking I/O in the event loopThe call to
os.statwas run in the executor but the call tois_file()was not. Additionally this resulted in two syscalls tostatsince bothis_fileandstatwill callstatunder the hood. The code has been refactored to ensure there is only onestatsyscall and it happens in the executorAre there changes in behavior for the user?
No
Related issue number
discovered while investigating #8011 but not does fix the issue reported
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.