Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8012/5f699bbb backport][3.10] Fix FileResponse doing blocking I/O in the event loop #8016

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Jan 10, 2024

This is a backport of PR #8012 as merged into master (5f699bb).

What do these changes do?

Fix FileResponse doing blocking I/O in the event loop

The call to os.stat was run in the executor but the call to is_file() was not. Additionally this resulted in two syscalls to stat since both is_file and stat will call stat under the hood. The code has been refactored to ensure there is only one stat syscall and it happens in the executor

Are there changes in behavior for the user?

No

Related issue number

discovered while investigating #8011 but not does fix the issue reported

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@bdraco bdraco merged commit 8de4188 into 3.10 Jan 11, 2024
26 of 30 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/5f699bbbf98d3700921ec9a7d646d5f21e82e8c1/pr-8012 branch January 11, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant